-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for many more MIRA probonto distributions #593
Conversation
@liunelson , why are some of the types for the parameters See e.g. |
@liunelson , it looks like you used Also, I'd like to add some tests to ensure these mappings are completed correctly. Do you have any example AMRs that use some of these new distributions? |
The Pyro Binomial distribution expects a You're right about the BetaBinomial distribution; it just wants |
I don't actually have any example of AMRs handy that use all these different probability distributions. However, MIRA has this test but it just directly invokes a |
Besides the type hinting of the |
See #590 for the original PR from @liunelson .